On Fri, 31 Jan 2025 21:09:12 GMT, Kevin Rushforth <[email protected]> wrote:
>> Andy Goryachev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> review comments
>
> tests/system/src/test/java/test/robot/javafx/scene/NodeInitializationBackgroundThreadTest.java
> line 732:
>
>> 730: private <T extends Node> void test(Supplier<T> generator,
>> Consumer<T> operation) {
>> 731: AtomicReference<T> ref = new AtomicReference();
>> 732: runAndWait(() -> {
>
> What was the rationale for this change? This means we are no longer testing
> the ability to construct a node off thread.
>
> Related to this, I think a separate set of tests where we construct instances
> of the node in a loop would be useful, in addition to the set of tests that
> mutates the node in a loop.
I think this change is why the Tooltip test is no longer failing. The failure
mode reported in [JDK-8348100](https://bugs.openjdk.org/browse/JDK-8348100)
happens when constructing Tooltip on a background thread.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1690#discussion_r1938010321
