On Tue, 4 Feb 2025 18:37:36 GMT, Jose Pereda <[email protected]> wrote:
>> Andy Goryachev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 25 25
>
> modules/javafx.graphics/src/main/java/com/sun/javafx/scene/text/TextLayout.java
> line 268:
>
>> 266: * @param start the start offset
>> 267: * @param end the end offset
>> 268: * @param the type of the geometry
>
> missing `type`after `@param`
eagle eye!
> modules/javafx.graphics/src/main/java/com/sun/javafx/text/PrismCaretInfo.java
> line 48:
>
>> 46: @Override
>> 47: public Rectangle2D getSegmentAt(int index) {
>> 48: return parts[index];
>
> do we need a bound check here?
no special handling is needed here I think: an exception will be thrown
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1596#discussion_r1943625519
PR Review Comment: https://git.openjdk.org/jfx/pull/1596#discussion_r1943626862
