On Thu, 13 Mar 2025 03:29:28 GMT, Michael Strauß <mstra...@openjdk.org> wrote:
>> This PR contains a definition of preview features for JavaFX, as well as a >> helper class to verify that an application has opted into preview features. > > Michael Strauß has updated the pull request incrementally with one additional > commit since the last revision: > > warning can be suppressed Looks good, with one naming suggestion. modules/javafx.base/src/main/java/com/sun/javafx/PreviewFeature.java line 50: > 48: > 49: private static final String ENABLE_PREVIEW_PROPERTY = > "javafx.enablePreview"; > 50: private static final String SUPPRESS_WARNING_PROPERTY = > "javafx.suppressPreviewBanner"; Perhaps `javafx.suppressPreviewWarning` would be a better name? ------------- PR Review: https://git.openjdk.org/jfx/pull/1359#pullrequestreview-2682439226 PR Review Comment: https://git.openjdk.org/jfx/pull/1359#discussion_r1993794327
