On Mon, 17 Mar 2025 15:08:00 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> modules/javafx.web/src/main/native/Source/WebCore/loader/cache/CachedResourceRequest.cpp
>> line 151:
>>
>>> 149: StringBuilder builder;
>>> 150: // Java platform failing to decode webp image data already disabled in
>>> 619.1
>>> 151: #if (HAVE(WEBP) || USE(WEBP)) && !PLATFORM(JAVA)
>>
>> I see that 619.1 indeed had:
>>
>> #if HAVE(WEBP) || USE(WEBP)
>> builder.append("image/webp,"_s);
>> #endif
>>
>> I wonder why the condition `!PLATFORM(JAVA)` is also required now?
>
> Likely those two flags are now defined (in 620.1), but weren't defined in
> 619.1. It is therefore safer to add the `!PLATFORM(JAVA)` and in any case any
> time we modify code from upstream, we should qualify it with a
> `PLATFORM(JAVA)` check.
Thanks, that makes sense
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1738#discussion_r1999051786
