On Tue, 18 Mar 2025 15:41:00 GMT, Ziad El Midaoui <zelmida...@openjdk.org> wrote:
>> Added multi line prompt support for TextArea this will provide the ability >> to have multiple lines in textArea as expected, >> Also fixed tests to meet the new changes > > I did test the mentioned line separators without filtering and the line > separators are not rendered as newlines, so there is no need to add filtering > for other line separators as they are already handled by default. > @Ziad-Mid : please do not resolve the conversations without the original > commenter confirming that the conversation is resolved (it's really a bug in > guthub, as only the originator of the comment can say if the conversation has > been resolved). I think there are still some questions left unanswered, > please check. > > (I've started to use thumbs-up emoji to mark the comment as addressed, if you > want my opinion). > > Other than that, the changes look good to me. I did unresolved them, and I will check the suggestions whenever possible and answer, thanks ------------- PR Comment: https://git.openjdk.org/jfx/pull/1716#issuecomment-2745022759
