On Mon, 24 Mar 2025 17:35:46 GMT, Martin Fox <[email protected]> wrote:
>> modules/javafx.graphics/src/main/java/com/sun/javafx/tk/quantum/QuantumToolkit.java
>> line 637:
>>
>>> 635: if (!canStartNestedEventLoop()) {
>>> 636: if
>>> (!Application.GetApplication().canStartNestedEventLoop()) {
>>> 637: throw new RuntimeException("Exceeded limit on nested
>>> event loops");
>>
>> should we tell what the limit is (using the static constant mentioned
>> earlier)?
>> e.g.
>> "Too many nested event loops (250)"? or something like that.
>
> The number is in the Mac-only Glass code and may change over time so it would
> be a maintenance burden to repeat it here. But if a developer does see this
> exception I'm sure their first question would be what the limit is. I can
> update the comment with something vague (like "over > 240") but I'm hoping
> that the very, very long Java stack trace attached to this exception will be
> enough.
Unless you are going to track the actual depth, I'd probably leave it as is.
When Java throws a StackOverflow it doesn't print the depth.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1741#discussion_r2010671459
