On Tue, 25 Mar 2025 21:55:54 GMT, Andy Goryachev <ango...@openjdk.org> wrote:

>> Changed the StubTextLayout to use product PrismTextLayout with much 
>> simplified glyph layout (via stubbed fonts).  The new layout assumes all the 
>> glyphs are squares of font size, while the bold type face produces wider 
>> glyphs (by 1 pixel).  The default font size has changed from 10 to 12 to 
>> make it closer to win/linux.
>> 
>> This brings the test environment closer to the product configuration and 
>> expands the capabilities of our headless testing pipeline, which will be 
>> useful for upcoming behavior tests.
>> 
>> Existing tests have been adjusted/reworked mainly due to default font size 
>> change.
>
> Andy Goryachev has updated the pull request with a new target base due to a 
> merge or a rebase. The incremental webrev excludes the unrelated changes 
> brought in by the merge/rebase. The pull request contains 30 additional 
> commits since the last revision:
> 
>  - review comments
>  - Merge remote-tracking branch 'origin/master' into 8342565.stub.text.layout
>  - Revert "fixed bad merge"
>    
>    This reverts commit 0e9e8ee63895bd1d976398587add5b96958d38aa.
>  - fixed bad merge
>  - review comments
>  - Merge remote-tracking branch 'origin/master' into 8342565.stub.text.layout
>  - Merge remote-tracking branch 'origin/master' into 8342565.stub.text.layout
>  - Merge remote-tracking branch 'origin/master' into 8342565.stub.text.layout
>  - Merge remote-tracking branch 'origin/master' into 8342565.stub.text.layout
>  - review comments
>  - ... and 20 more: https://git.openjdk.org/jfx/compare/e5cd72b9...ad193db5

Newest changes look good as well.

-------------

Marked as reviewed by mhanl (Committer).

PR Review: https://git.openjdk.org/jfx/pull/1667#pullrequestreview-2716933889

Reply via email to