On Wed, 26 Mar 2025 21:36:22 GMT, John Hendrikx <jhendr...@openjdk.org> wrote:
>> the original code had some logic around `(pos == null)`, I wonder if we need >> to do the same here, that is, derive the effective alignment from both >> values? > > That was just for deriving the `hpos` and `vpos` fields, which are no longer > needed, in case `pos` was `null`. The `null` check is now handled in > `LabeledSkinBase`. > > Of course we could think of some kind of derive option (how to derive LEFT + > RIGHT?) or a way to remove one of these, but I think either way, it's outside > the scope of this change. I added the comment for future maintainers (I > could have left it out, and we'd probably not be having this discussion). > > As it is, I don't think we should fix this as part of this change as it is > really completely unrelated (and might need much more discussion and perhaps > even a CSR...) > > Perhaps I should remove the comment and instead we describe this in an issue? I agree: this change is out of scope for this PR. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1742#discussion_r2015044999
