On Fri, 28 Mar 2025 08:56:36 GMT, Jayathirth D V <j...@openjdk.org> wrote:
> SwingNodePlatformExitCrashTest hangs while running on wayland, we need to > skip this test on wayland until https://bugs.openjdk.org/browse/JDK-8350009 > is fixed. LGTM with one inline suggestion about adding the bug ID being used to skip this test (JDK-8350009). Regarding [JDK-8350009](https://bugs.openjdk.org/browse/JDK-8350009), I was finally able to test this on my Ubuntu 24.04 VM after resetting the Wayland screencast token (I had some problem with my system earlier). After doing this, the test only hangs for me on JDK 23. When I run it on JDK 24 it now reliably passes for me. More testing is needed, though, so go ahead and integrate this fix to skip the test on Wayland after adding the bug ID. If we then find out that it runs reliably on multiple systems when using JDK 24, you can fix [JDK-8350009](https://bugs.openjdk.org/browse/JDK-8350009) by adding the check for JDK version so that it will only skip on Wayland for JDK 23 and earllier. tests/system/src/test/java/test/robot/javafx/embed/swing/SwingNodePlatformExitCrashTest.java line 57: > 55: @BeforeAll > 56: public static void skipShutDown() { > 57: Assumptions.assumeTrue(!Util.isOnWayland()); Please add `// JDK-8350009` in a comment, either at the end of this line or on a line by itself before this). ------------- PR Review: https://git.openjdk.org/jfx/pull/1745#pullrequestreview-2726639820 PR Review Comment: https://git.openjdk.org/jfx/pull/1745#discussion_r2019294250
