On Fri, 21 Mar 2025 08:17:39 GMT, Jay Bhaskar <jbhas...@openjdk.org> wrote:
> Issue: > Ref: Webkit 619.1 > javafx.web/src/main/native/Source/WebCore/platform/graphics/ImageSource.cpp > refactoring in 620.1 > In the case of the canvas pattern using a transform property filled with an > SVGMatrix() > created by an SVG element, `frame.m_nativeImage->size()` calls > `NativeImage::size()` > from NativeImageJava.cpp. In this scenario, > `*m_platformImage->getImage().get()` may be invalid, > as the image decoder has already populated `frame.m_size` during image > metadata caching. > > Solution: > To avoid potential invalid accesses and unintended size resets, only update > `m_size` > if the frame does not already have a valid native image. The fix looks good to me. I confirmed that the formerly crashing CanvasTest now passes for me on my Mac M1. I'll do some additional testing before approving. ------------- PR Comment: https://git.openjdk.org/jfx/pull/1740#issuecomment-2743317756
