On Wed, 26 Mar 2025 14:36:39 GMT, Andy Goryachev <ango...@openjdk.org> wrote:
>> Fixed several issues found in importing RTF text: >> >> - charset translation (brought back removed code) >> - missing font size attribute >> - missing strike-through attribute >> >> Also, HTML copy suffered from the following issues: >> >> - incorrect font size >> - incorrect handling of boolean character attributes (bold, italic, etc.) >> >> The charset issue was caused by my removal of the character decoder code >> present in the original JDK RTF parser/reader. Why did I do that? >> >> This PR does not add import of RTL paragraph attribute needed to align RTL >> text correctly. > > Andy Goryachev has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains 10 additional > commits since the last revision: > > - Merge remote-tracking branch 'origin/master' into 8351878.rtf > - html > - Merge remote-tracking branch 'origin/master' into 8351878.rtf > - arabic > - whitespace > - test > - strikethrough > - missing code in attr set > - font size > - fixed arabic import LGTM - did some testing, both with issue-attached Word file and some standard Polish diacritic test sentences and everything seems to work fine. Question coming from my own curiosity - when you post a sentence containing diacritics (ex. shortest tester for all diacritics in Polish - "Zażółć gęślą jaźń") you can see that some fonts don't support those special characters (ex. Arial Rounded MT Bold on Windows) so as a fallback they are drawn with a different font that supports them. It's quite normal behavior to do so I've seen often, but do you know what is the process for determining which font to use as a replacement in RTA? Is it something we have to worry about? ------------- Marked as reviewed by lkostyra (Reviewer). PR Review: https://git.openjdk.org/jfx/pull/1735#pullrequestreview-2742887263
