On Fri, 4 Apr 2025 17:04:26 GMT, Andy Goryachev <ango...@openjdk.org> wrote:
>> Jay Bhaskar has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains five additional >> commits since the last revision: >> >> - Merge remote-tracking branch 'upstream/master' into juni5bastest >> - missing review change and remove trailing white space >> - simplify test setup according to review >> - remove trailing white space >> - 8340464: [TestBug] Convert parametrized base tests to JUnit 5 > > modules/javafx.base/src/test/java/test/javafx/util/converter/DateStringConverterTest.java > line 108: > > > what was the reason for this code (LL108 - 114) removal? > and for the removal of the tests from L136? > > this removal also makes `private DateFormat validFormatter;` unused re-written entire test gain according others ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1759#discussion_r2029705711
