On Fri, 11 Apr 2025 09:37:12 GMT, Gopal Pattnaik <d...@openjdk.org> wrote:

> There was a Assertion fail issue in mouse location test case JDK-8296554,
> Reason: We felt the one mili second delay time for the Robot test may be 
> insufficient in few OS.
> Solution: We Changed the delay time to three mili second.
> 
> Verification:
> Tested in Windows 11, and the Assert fail issue is not found.

I observe the following behavior:

* On my Mac laptop, this makes the test take nearly three times as long -- 48 
sec (use to take 17 sec), which is expected given that `sleep(DELAY)` is done 
in the inner loop.
* On my Windows laptop, this makes the test take twice as long -- 56 sec (use 
to take 28 sec)

This is getting to be about as much time as I would want this test to take, so 
I wouldn't increase it beyond 3ms without some evidence that it is needed.

What testing have you done to ensure that this is sufficient? Have you seen 
this fail on a particular system with a given load, and then observed that 
under the same conditions the updated test now passes?

-------------

PR Review: https://git.openjdk.org/jfx/pull/1772#pullrequestreview-2761203672

Reply via email to