On Mon, 14 Apr 2025 15:06:15 GMT, Andy Goryachev <ango...@openjdk.org> wrote:

>> Thiago Milczarek Sayao has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   Missed one change
>
> modules/javafx.graphics/src/main/java/com/sun/glass/events/WindowEvent.java 
> line 43:
> 
>> 41:      * and {@link #UNMINIMIZE}.
>> 42:      */
>> 43:     @Deprecated
> 
> I am curious: what would be the benefit of deprecating, as opposed to 
> redefining?
> Is there a possibility of a mismatch between the java code and the native?

My idea is to update all platforms for consistency and eventually remove it, 
since it's for internal use.

I think this area might be broken on native code and it'll need some update.

This branch has this change as well as I'm fixing native Linux glass code to 
cope with it:
https://github.com/openjdk/jfx-sandbox/tree/glass_gtk_bug_squashing

This test (on the branch) does some mixing of States:
`gradlew -PFULL_TEST=true -PUSE_ROBOT=true :systemTests:test --tests 
StageStatesTest`

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1777#discussion_r2042376280

Reply via email to