On Wed, 16 Apr 2025 16:23:14 GMT, Kevin Rushforth <[email protected]> wrote:
>> Andy Goryachev has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains two additional
>> commits since the last revision:
>>
>> - Merge remote-tracking branch 'origin/master' into 8088343.lifecycle
>> - 8088343
>
> modules/javafx.graphics/src/main/java/javafx/concurrent/Task.java line 1021:
>
>> 1019: switch (getState()) {
>> 1020: case FAILED:
>> 1021: case SUCCEEDED:
>
> Avoiding transitioning from a one of the completion states to canceled is a
> good thing. My question, though is: how did we get here? Is this masking some
> other problem?
I think the variations in the test timing uncovered this issue. I don't think
it's a problem with the execution of the task, but rather with the reporting of
its final state.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1769#discussion_r2047660750
