On Wed, 16 Apr 2025 15:13:23 GMT, Gopal Pattnaik <[email protected]> wrote:
>> There was a Assertion fail issue in mouse location test case JDK-8296554,
>> Reason: We felt the one mili second delay time for the Robot test may be
>> insufficient in few OS.
>> Solution: We Changed the delay time to three mili second.
>>
>> Verification:
>> Tested in Windows 11, and the Assert fail issue is not found.
>
> Gopal Pattnaik has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Addressed Review comments
The updated test looks good to me. I noted one unnecessary boxed primitive.
tests/system/src/test/java/test/robot/javafx/scene/MouseLocationOnScreenTest.java
line 122:
> 120: */
> 121: static void validate(Robot robot, int x, int y) {
> 122: Boolean equalValue = false;
There is no need to box the primitive in a `Boolean` object here:
`Boolean` --> `boolean`
-------------
PR Review: https://git.openjdk.org/jfx/pull/1772#pullrequestreview-2773255181
PR Review Comment: https://git.openjdk.org/jfx/pull/1772#discussion_r2047372227
