On Wed, 16 Apr 2025 23:27:23 GMT, John Hendrikx <jhendr...@openjdk.org> wrote:
> If you still need one, I can provide a bit of code.
Thanks, that's ok, I would rather add the Dialog page to the MT, as it will
allow for more extensive testing.
>> modules/javafx.controls/src/main/java/javafx/scene/control/DialogPane.java
>> line 822:
>>
>>> 820: final ObservableList<String> styleClasses =
>>> detailsButton.getStyleClass();
>>> 821:
>>> 822: styleClasses.add("details-button"); //$NON-NLS-1$
>>
>> do we use these `//$NON-NLS-1$` in jfx?
>
> I do not know if we do, as there is also non-public code that I don't have
> access to. I've kept them as-is to make sure the change is focused and
> doesn't break anything else.
>
> If I had to guess then probably not, if you can ask around and find out I'll
> be happy to remove them.
I'll double check and will let you know tomorrow.
-------------
PR Comment: https://git.openjdk.org/jfx/pull/1779#issuecomment-2811093389
PR Review Comment: https://git.openjdk.org/jfx/pull/1779#discussion_r2047928744
