On Mon, 14 Apr 2025 21:04:30 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> Fixes a link error that occurs when using C++14 to compile and link JavaFX >> on Linux. >> >> >> in function `PlatformSupport::PlatformSupport(JNIEnv_*, _jobject*)': >> PlatformSupport.cpp:90: undefined reference to >> `PlatformSupport::OBSERVED_SETTINGS' >> >> >> The solution, proposed by @johanvos, is to define >> `PlatformSupport::OBSERVED_SETTINGS` in `PlatformSupport.cpp`. >> >> I have tested this using gcc 13.2 and 14.2 using C++17 and it builds and >> runs as expected. Johan has already tested a variant of this on C++14, but I >> will wait for his explicit review. > > Kevin Rushforth has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains two additional > commits since the last revision: > > - Merge remote-tracking branch 'upstream/master' into 8353632-PlatformSupport > - 8353632: [Linux] Undefined reference to PlatformSupport::OBSERVED_SETTINGS > with C++14 When this patch is applied, building the OpenJFX native code for gtk works fine using the OpenJDK build process (tools/compiler). ------------- Marked as reviewed by jvos (Reviewer). PR Review: https://git.openjdk.org/jfx/pull/1768#pullrequestreview-2790286649
