On Thu, 24 Apr 2025 14:36:33 GMT, Michael Strauß <mstra...@openjdk.org> wrote:
>> modules/javafx.graphics/src/main/java/javafx/stage/StageStyle.java line 113:
>>
>>> 111: * of the {@code Scene} to remain easily recognizable.
>>> Applications should set the scene fill to a color
>>> 112: * that matches the brightness of the user interface, even if the
>>> scene fill is not visible because it
>>> 113: * is obscured by other controls.
>>
>> Can we add the reasoning for this? When deciding on the actual color, it
>> would be useful to know when exactly it may be shown.
>
> How a scene background is shown is already described in `Scene.fill`. Note
> that if we get #1655, we might want to change this part of the specification
> such that the color scheme of the buttons adjusts to the color scheme of the
> scene (i.e. `Scene.Preferences.colorScheme`) and not to its background fill.
Ah, so I think I misunderstood this. Maybe change "is adjusted to" to "is
adjusted to match" or "is bound to" so it's clear the fill color is used as the
background, and not something else based on it. Also, add "elsewhere" after "is
not visible" so it's clear the scene fill is actually shown as the button
background.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1605#discussion_r2058648136
