On Wed, 23 Apr 2025 19:48:52 GMT, Martin Fox <[email protected]> wrote:
>> Thiago Milczarek Sayao has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Reenable RestoreSceneSizeTest (JDK-8353556)
>
> tests/system/src/test/java/test/javafx/stage/FullScreenTest.java line 123:
>
>> 121: mode = EnumSource.Mode.INCLUDE,
>> 122: names = {"DECORATED", "UNDECORATED", "TRANSPARENT"})
>> 123: void testUnFullScreenChangedSize(StageStyle stageStyle) {
>
> According to the spec changes to the size or position of a window while it's
> in fullscreen mode will be ignored and applied after the window leaves
> fullscreen mode. That's not how it currently works on macOS or Windows 11.
> Actually implementing that part of the spec would be complicated and probably
> not worth the development cycles. I would rather remove that wording and drop
> the testUnFullScreenChangeSize and Position tests.
>
> I imagine this was easy to implement back when fullscreen was implemented as
> a separate window. It's not clear this is useful behavior, the spec might
> just have captured an implementation detail and elevated it to a feature.
I was kind of on the fence with this one. Maybe it’s a case where the docs in
Stage.java need fixing — they do also say that width and height should reflect
the unfullscreened size. But there are several tests that check the fullscreen
size against the screen size, so I opted for notifying the fullscreen sizes.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1789#discussion_r2059342932
