On Wed, 16 Apr 2025 19:00:53 GMT, Marius Hanl <mh...@openjdk.org> wrote:
>> With this change, you can now run the `swt` tests as easy as: `:swt:test >> -PSWT_TEST=true`. >>  >> >> Note: At one point `IS_FULL_TEST` was used as well for the enablement of the >> tests. I don't see any reason for it, and one flag seems to be enough to me. >> But open for opinions on this one. > > Checking the GHA build, `IS_FULL_TEST` actually might be needed. Linux fails > with `org.eclipse.swt.SWTError: No more handles [gtk_init_check() failed]` > when creating the `Display`. > @Maran23 what platforms did you test this on? Windows? Yes, Windows 11. > change its default to "false" on macOS ("true" otherwise) Yes this seems like a good idea, I think it is more clean to have the definition where the property is (with the conditional for MacOS), instead of the `test{}` block, as you also suggested. I want to check the tests on MacOS (See if I can figure out why they fail) and Linux (checkout `testImageCursor`) if time permits, but I might not be able to make it. ------------- PR Comment: https://git.openjdk.org/jfx/pull/1783#issuecomment-2834610822
