On Wed, 30 Apr 2025 23:34:06 GMT, Martin Fox <m...@openjdk.org> wrote:

>> On macOS the system animates the transition into and out of fullscreen and 
>> this animation runs asynchronously. JavaFX tries to make the setFullScreen 
>> call appear synchronous by running a nested event loop while the transition 
>> is going on. But this means that runLater runnables can fire during a call 
>> to setFullScreen.
>> 
>> This can also occur during a call to Window.hide() if the window is in 
>> fullscreen mode. During the setView call glass tries to take the window out 
>> of fullscreen mode which fires up a nested event loop and, again, runLater 
>> runnables (like pulses) start firing.
>> 
>> In this PR GlassRunnables that try to run during the fullscreen transition 
>> are instead placed in a deferral list. When the fullscreen event loop exits 
>> they are re-scheduled.
>
> Martin Fox has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Disabling testDemaximizedPosition (again). Seems to be failing on some test 
> machines.

New stage attribute tests are being written for PR #1789. I'll get some 
dual-monitor tests added and try to ensure they push the system a bit (like 
trying to trigger this bug).

Just realized that some of the existing tests expect that when a stage is taken 
out of fullscreen or maximized mode you will see one and only one update to the 
size and position properties. I'm not entirely sure that's a requirement we 
should be testing for.

-------------

PR Comment: https://git.openjdk.org/jfx/pull/1797#issuecomment-2847375332

Reply via email to