On Mon, 5 May 2025 21:28:08 GMT, Ziad El Midaoui <zelmida...@openjdk.org> wrote:

>> The issue was happening because `-fx-highlight-text-fill` was set to white , 
>> so when the background color is bright (>60% brightness ) the text is not 
>> visible , the solution is to change the value to be dynamically set 
>> depending on the level of brightness of the background this is done by 
>> `-fx-focused-text-base-color` .
>
> Ziad El Midaoui has updated the pull request with a new target base due to a 
> merge or a rebase. The incremental webrev excludes the unrelated changes 
> brought in by the merge/rebase. The pull request contains five additional 
> commits since the last revision:
> 
>  - Merge branch 'openjdk:master' into 8355012.modenaCss
>  - Added standard copyright, javadoc and changed file name to 
> TextInputControlModenaTest
>  - Added standard copyright, javadoc and changed file name to 
> TextInputControlModenaTest
>  - Created ModenaTest
>  - Changed value of -fx-highlight-text-fill to be dynamically set and added 
> tests

Thank you all for your reviews and feedback!

-------------

PR Comment: https://git.openjdk.org/jfx/pull/1801#issuecomment-2858815651

Reply via email to