On Fri, 2 May 2025 15:44:03 GMT, Andy Goryachev <ango...@openjdk.org> wrote:
>> Moving MenuBarSkin initialization code to install() which always happens in >> the FX Application Thread. >> >> Also, ensure that the reverse process also happens in the FX application >> thread. > > Andy Goryachev has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains three additional > commits since the last revision: > > - Merge remote-tracking branch 'origin/master' into 8355615.menubar > - in fx thread > - install Looks good. The test doesn't fail on my system even without the fix, but the race condition you are fixing has a narrow window, so that's OK. ------------- Marked as reviewed by kcr (Lead). PR Review: https://git.openjdk.org/jfx/pull/1795#pullrequestreview-2829558872
