On Wed, 7 May 2025 17:09:12 GMT, Martin Fox <m...@openjdk.org> wrote:
>> Thiago Milczarek Sayao has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix non-debug build
>
> tests/system/src/test/java/test/robot/javafx/stage/StageOwnershipTest.java
> line 343:
>
>> 341: () -> {
>> 342: assertTrue(stage0.isIconified());
>> 343: assertTrue(stage1.isIconified());
>
> When a window is iconified I would expect the OS to hide any owned windows
> but not iconify them. For example, the owned windows should not appear as
> thumbnails in the dock or task bar. If we want these to be reported as
> iconified we would have to update glass to do that.
>
> My first impulse is to not change anything but currently JavaFX has no way of
> knowing that the owned windows have changed state and can't be drawn to. We
> can't report them as hidden because that means something else in JavaFX.
> Modifying glass to report them as iconified might actually be the right thing
> to do even though they're not actually iconified.
I removed the children iconified assertions and kept the color checks.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1789#discussion_r2083509958
