On Mon, 19 May 2025 15:30:17 GMT, Andy Goryachev <ango...@openjdk.org> wrote:
>> I've removed the system property, so there's a hard-coded limit of 100 >> exceptions now. > > 100 still looks excessive to me - it's unlikely that we'll have two different > scenarios when this happens, so most of the time the log will have 100 > identical traces. > > I mean, one is probably enough, we could have 2 or 4 just to drive the > message home. Anything beyond 8 is simply annoying, don't you think? In general, we shouldn't suppress any exceptions that would otherwise be logged. The only thing that makes this case a bit different is that with a periodic timer, there's the potential for an inflated log that grows without bounds. I think that defining a reasonable upper limit is enough to prevent that; in particular, I think we shouldn't try to assume that any particular number of logged failures (like 1 or 4) is "enough" for application developers. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1811#discussion_r2096251535
