On Thu, 5 Jun 2025 00:44:00 GMT, Michael Strauß <mstra...@openjdk.org> wrote:

>> modules/javafx.graphics/src/main/native-glass/gtk/glass_window.cpp line 1418:
>> 
>>> 1416: 
>>> 1417:     gdk_window_show_window_menu(gdk_window, event);
>>> 1418:     gdk_event_free(event);
>> 
>> The `seat` concept was introduced in gtk 3.20  and 
>> `gdk_window_show_window_menu` was in 3.14, and we require 3.8.  
>> I would agree that it's time to bump it up.
>
> Is there anything we need to change here?

We can bump up required Gtk version (with another PR) to 3.20 (it's from 2016, 
so pretty old), or replace the `gdk_window_show_menu` with X11 calls.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1605#discussion_r2128644400

Reply via email to