On Thu, 19 Jun 2025 22:13:37 GMT, Michael Strauß <mstra...@openjdk.org> wrote:
>> Johan Vos has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix missing ;
>
> modules/javafx.graphics/src/main/java/com/sun/glass/ui/headless/HeadlessRobot.java
> line 277:
>
>> 275: modifiers |= KeyEvent.MODIFIER_BUTTON_FORWARD;
>> 276: break;
>> 277: }
>
> Using an expression can help increase readibility and correctness:
> Suggestion:
>
> modifiers |= switch (buttons[i]) {
> case NONE -> KeyEvent.MODIFIER_NONE;
> case PRIMARY -> KeyEvent.MODIFIER_BUTTON_PRIMARY;
> case MIDDLE -> KeyEvent.MODIFIER_BUTTON_MIDDLE;
> case SECONDARY -> KeyEvent.MODIFIER_BUTTON_SECONDARY;
> case BACK -> KeyEvent.MODIFIER_BUTTON_BACK;
> case FORWARD -> KeyEvent.MODIFIER_BUTTON_FORWARD;
> };
suggestion is merged
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1836#discussion_r2160919763
