On Tue, 24 Jun 2025 16:38:48 GMT, Marius Hanl <[email protected]> wrote:
>> Johan Vos has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Process reviewer comments
>
> modules/javafx.graphics/src/main/java/com/sun/glass/ui/headless/HeadlessApplication.java
> line 138:
>
>> 136: @Override
>> 137: protected Screen[] staticScreen_getScreens() {
>> 138: final int screenWidth = 1000;
>
> Should this be something that can be configured by the developer? E.g. a
> simple system property with a default value of 1000?
This is a good question, and I believe it is part of a broader discussion.
There are a number of places (e.g. here) where I use hardcoded, default values
which should be fine for most usecases I'm aware of. However, I believe there
is definitely value in having more configurable values (e.g. in screen
dimensions, but also number of screens, default window sizes, multiclick values
etc).
The challenge with this is that we need some way to have developers manipulate
these values, for example using system properties (as you state as well). This
is then adding a feature that doesn't exist yet, so it would require a deeper
discussion on how to make the Headless platform configurable. I'm absolutely +1
on that, but I believe it would be easier if we do that as a follow-up?
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1836#discussion_r2169956391
