On Fri, 18 Jul 2025 17:54:46 GMT, Ambarish Rapte <ara...@openjdk.org> wrote:

>> Good catch. I think this should throw a `RuntimeException` of some sort.
>
> We throw an InternalError from MTLResourceFactory.createStockShader() if 
> shader creation fails. For matching changed here to use InternalError. If not 
> Ok, then I shall change it. please check.

`InternalError` is fine. I was going to suggest that as another alternative (we 
often use that for errors that should never happen and aren't a result of 
something the app did).

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1824#discussion_r2216843322

Reply via email to