On Mon, 28 Jul 2025 11:38:26 GMT, Johan Vos <j...@openjdk.org> wrote:

>> After spending a year in the sandbox repository, the Headless Platform is 
>> now ready to be reviewed in the main repository.
>> 
>> ### the Headless Platform
>> The Headless Platform is a top-level com.sun.glass.ui platform that replaces 
>> the second-level Monocle-Headless subplatform, that is part of the top-level 
>> Monocle platform. 
>> The platform can be used like any other platform, especially for running 
>> headless JavaFX applications, or for running tests (e.g. on CI systems)
>> 
>> ### changes
>> The code for the Headless Platform is in a new package 
>> com.sun.glass.ui.headless in the javafx.graphics module, and it does not 
>> require a code change in other packages.
>> This PR adds a simple change in the `build.gradle` file, to make the 
>> Headless Platform the standard when running headless tests (instead of using 
>> Monocle/Headless)
>> 
>> ### enable the Headless Platform
>> Setting the system property `glass.platform` to `Headless` will select the 
>> Headless Platform instead of the default one (either gtk, mac or win).
>> 
>> ### testing
>> `gradlew --info -PHEADLESS_TEST=true -PFULL_TEST=true :systemTests:cleanTest 
>> :systemTests:test`
>> runs all the system tests, apart from the robot tests. There are 2 failing 
>> tests, but there are valid reasons for those to fail.
>> 
>> ### robot tests
>> Most of the robot tests are working on headless as well. add `-PUSE_ROBOT` 
>> to test those.
>
> Johan Vos has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Remove modal support implementation

Marked as reviewed by angorya (Reviewer).

modules/javafx.graphics/src/main/java/com/sun/glass/ui/headless/HeadlessWindow.java
 line 56:

> 54:     private HeadlessRobot robot;
> 55: 
> 56:     private final int stride = 1000;

I see you've created [JDK-8364201](https://bugs.openjdk.org/browse/JDK-8364201) 
for the configuration options, thank you.

-------------

PR Review: https://git.openjdk.org/jfx/pull/1836#pullrequestreview-3063150496
PR Review Comment: https://git.openjdk.org/jfx/pull/1836#discussion_r2236790770

Reply via email to