On Wed, 30 Jul 2025 21:39:37 GMT, Andy Goryachev <ango...@openjdk.org> wrote:

>> Martin Fox has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   Cleaned up diff against master. Tighted up system test (tested on Windows 
>> and Linux)
>
> tests/system/src/test/java/test/javafx/stage/RestoreStagePositionTest.java 
> line 130:
> 
>> 128: 
>> 129:         Platform.runLater(() -> stage.setMaximized(true));
>> 130:         Thread.sleep(800);
> 
> Would the `test.util.Util.waitForIdle()` be of use here?  Or `runAndWait()` ?

Yes on the runAndWait (always a good idea in cases like this where you aren't 
otherwise latching), but no on the change to use waitForIdle (see my other 
comment).

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1860#discussion_r2257848016

Reply via email to