On Sat, 9 Aug 2025 18:25:49 GMT, Thiago Milczarek Sayao <tsa...@openjdk.org>
wrote:
>> tests/system/src/test/java/test/robot/javafx/stage/StageOwnershipTest.java
>> line 204:
>>
>>> 202: @ParameterizedTest(name = PARAMETERIZED_TEST_DISPLAY)
>>> 203: @MethodSource("getTestsParams")
>>> 204: void
>>> openingModalChildStageWhileFullScreenShouldHaveFocus(StageStyle stageStyle,
>>> Modality modality)
>>
>> This test is passing on macOS but it's causing beeps. When the test is being
>> torn down it's trying to hide the fullscreen window first even though it
>> owns a visible modal window. After the window exits fullscreen the OS always
>> tries to make it the key window (!?) even though JavaFX considers it
>> disabled and this is causing Glass to beep and issue the FOCUS_DISABLED
>> message.
>>
>> There's nothing wrong with this test but it is inadvertently testing how the
>> system deals with hiding a window while it owns a modal. But my main concern
>> is that other macOS developers are going to be repeatedly tracking down
>> where the beeps are coming from.
>
> Added a text description on the full screen exit hint. Will also show up if
> searching for "beep".
Good enough. Thanks.
>> tests/system/src/test/java/test/robot/javafx/stage/StageOwnershipTest.java
>> line 287:
>>
>>> 285: () -> {
>>> 286: assertTrue(stage0.isIconified());
>>> 287: assertColorDoesNotEqual(COLOR0, stage0);
>>
>> Are these the correct tests? If all stages are iconified you'll be picking
>> up random colors from the desktop. One of those random colors might just
>> match one of the color constants here.
>
> I fixed the method name, but I think the test is correct - it does get a
> random color, but it tests for no match.
Since it picks up a random color it could get a match by accident. Highly
unlikely but possible.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1789#discussion_r2276920131
PR Review Comment: https://git.openjdk.org/jfx/pull/1789#discussion_r2276923455
