On Mon, 18 Aug 2025 19:31:16 GMT, Nir Lisker <nlis...@openjdk.org> wrote:

>> modules/javafx.graphics/src/main/java/javafx/scene/Node.java line 7718:
>> 
>>> 7716:     }
>>> 7717: 
>>> 7718:     /// Defines a function to be called when a full 
>>> press-drag-release gesture ends with this node as its source.
>> 
>> This is the first instance of markdown-style javadoc comments in JavaFX. Do 
>> we need a discussion surrounding their use?
>
> They were added in JDK 23, which we can use. I don't know if there's anything 
> special to discuss. The JEP gives standard usage examples, which I've 
> followed, so there's no "feature abuse" here either.

Well, they look very different from the other style. Usually matters of style 
are settled once in a style guide, which we don't have. But I think we should 
at least consciously agree that we're fine with having two different styles of 
documentation in the same project. Personally, I value uniformity of style more 
than the (little) added value that markdown comments bring.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1873#discussion_r2283373284

Reply via email to