On Mon, 8 Sep 2025 11:16:17 GMT, Hima Bindu Meda <hm...@openjdk.org> wrote:

> Updated libxml2 to v2.14.5.
> Verified build on all platforms. No issues seen

Testing looks good. Code changes look good and match the upstream, although I 
noticed that there are two files that we have in our repo that are not in the 
upstream repo:

* `src/nanoftp.c` -- removed as part of this update (i.e., removed between 
`v2.13.8` and `v2.14.5`)
* `src/buf.h` -- removed a couple updates ago (it moved to 
`include/private/buf.h` between `v2.10.4` and `v2.12.6` so now we have two 
copies)

I recommend either removing them or filing a follow-up cleanup bug to do so.

I'll approve it as-is. If you decide to make changes I'll reapprove.

-------------

Marked as reviewed by kcr (Lead).

PR Review: https://git.openjdk.org/jfx/pull/1886#pullrequestreview-3203162915

Reply via email to