On Thu, 18 Sep 2025 08:50:44 GMT, Jayathirth D V <[email protected]> wrote:
>> Added `test.screenshot` system property to the `ScreenCaptureTestWatcher` to
>> control writing of the screenshot data url to stderr.
>>
>> Added corresponding gradle option `TEST_SCREENSHOT`.
>>
>> The function is disabled by default for privacy reasons.
>
> tests/system/src/test/java/test/util/ScreenCaptureTestWatcher.java line 36:
>
>> 34: * {@code -Dtest.screenshot=true} command line argument.
>> 35: * <p>
>> 36: * Using Safari, the screenshot {@code data:} URL can be pasted into the
>> address bar
>
> Tested with Safari, Firefox and Chrome. Only Chrome has limitation of length
> for large data URL's and truncates the image. If the desktop is large/diverse
> enough even Safari is not able to load the data URL's in my Macbook. May be
> we should make generic statement and mention Safari worked better for us.
I don't have objection to mentioning "Safari" only, since it is already
mentioned in the same file before.
But i feel the statement can be improved to include firefox also, then we are
not limited to specific platform.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1910#discussion_r2359454719
