On Thu, 18 Sep 2025 15:19:23 GMT, Andy Goryachev <[email protected]> wrote:
>> This PR removes unrelated `stderr` output in the headless test logs by >> redirecting it to an in-memory buffer. Exceptions found in the buffer can >> be checked against the expected list. >> >> In the case when any mismatch is detected, whether the type or the number of >> exceptions of particular type, the accumulated buffer gets dumped to >> `stderr` and the test fails. >> >> ## How To >> >> To redirect stderr and later check the exceptions, surround your code with >> >> `OutputRedirect.suppressStderr()` and either `OutputRedirect.checkStderr()` >> or `OutputRedirect.checkAndRestoreStderr()` (ideally, in the `finally` >> block). >> >> To simply undo redirection, without checking, call >> `OutputRedirect.restoreStderr()`. >> >> To add the check to all the tests in the file, one can call the above >> mentioned methods inside `@BeforeEach` and `@AfterEach`. >> >> ## Changes >> >> - added `OutputRedirect` facility >> >> ## Miscellaneous >> >> `ErrorLoggingUtiltity` name will be fixed in a followup >> https://bugs.openjdk.org/browse/JDK-8367995 > > Andy Goryachev has updated the pull request incrementally with one additional > commit since the last revision: > > reverted renaming modules/javafx.base/src/test/java/test/com/sun/javafx/binding/SelectBindingTest.java line 111: > 109: public void setUp() throws Exception { > 110: OutputRedirect.suppressStderr(); > 111: ErrorLoggingUtiltity.reset(); Moving the call to `reset` to a `@BeforeEach` method is an unrelated change. It seems safer to restore the `@BeforeAll` method with just the call to reset. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1897#discussion_r2359868514
