On Thu, 18 Sep 2025 18:38:03 GMT, Kevin Rushforth <[email protected]> wrote:
>> Andy Goryachev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> review comments
>
> tests/system/src/test/java/test/javafx/scene/Snapshot1Test.java line 244:
>
>> 242: } finally {
>> 243:
>> OutputRedirect.checkAndRestoreStderr(ClassCastException.class);
>> 244: }
>
> This fails for me, which is not surprising since the snapshot is
> asynchronous. You probably want to move everything (the suppressStderr and
> the try/finally with the checkAndRestoreStderr) out of the runAndWait, but
> even that might not be sufficient without a delay after `latch.getCount()`.
you are right, I missed the `runAndWait()`
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1897#discussion_r2360696605
