On Wed, 1 Oct 2025 16:24:06 GMT, Kevin Rushforth <[email protected]> wrote:

>> modules/javafx.graphics/src/test/java/test/javafx/scene/ParentTest.java line 
>> 646:
>> 
>>> 644:         assertEquals(LayoutFlags.CLEAN, 
>>> ParentShim.getLayoutFlag(level2));
>>> 645:         assertEquals(LayoutFlags.CLEAN, 
>>> ParentShim.getLayoutFlag(leaf));
>>> 646:         assertEquals(LayoutFlags.CLEAN, 
>>> ParentShim.getLayoutFlag(sibling));
>> 
>> Excellent test, thank you!
>> 
>> Question:
>> When a situation like this happens in reality, we might see a momentary 
>> flicker due to the layout spanning several pulses, correct?
>> The platform itself can't really do anything, except for the application 
>> code to call the layout() explicitly to avoid flicker, right?
>
> This is already the case irrespective of this PR. The point of this PR is to 
> ensure that the flags are consistently set as to which part(s) of the scene 
> graph are dirty and need to be reevaluated for the next layout pass.

We should probably resurrect #433 at some point.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1879#discussion_r2395189255

Reply via email to