On Wed, 8 Oct 2025 20:46:12 GMT, Alexander Zuev <[email protected]> wrote:
>> Create the accessibility peer for menu bar component also fix the problem >> when with the voiceover is on the <Ctrl>-F10 is pressed the name of the >> selected menu is not announced. > > Alexander Zuev has updated the pull request incrementally with one additional > commit since the last revision: > > Cover the case when menu item has children but it does not respond to the > accessibilityValue selector; LGTM, With a minor query. I shall re-approve if query results in a change. modules/javafx.graphics/src/main/native-glass/mac/a11y/JFXMenuItemAccessibility.m line 46: > 44: return @""; > 45: } > 46: return title; Minor query: Is `return @""` statement required ? Cant' we rely on `return title;` (which would return nil in case) ? ------------- Marked as reviewed by arapte (Reviewer). PR Review: https://git.openjdk.org/jfx/pull/1927#pullrequestreview-3318173968 PR Review Comment: https://git.openjdk.org/jfx/pull/1927#discussion_r2416246855
