I wonder if we should find out exactly why onFocusLost does not work in these cases, as expected. Then, if I understand the proposal correctly, we won't need any API changes.
-andy From: openjfx-dev <[email protected]> on behalf of John Hendrikx <[email protected]> Date: Monday, October 13, 2025 at 07:17 To: [email protected] <[email protected]> Subject: Re: Allowing a cell to commit the value on focus loss Hi Marius, This may be unrelated, but it may be problematic to rely on committing values using focus lost: I've built a lot of code that relies on focus lost to "commit" values to some underlying model. However, I noticed that a focus lost handler for committing values is insufficient when an action is triggered that doesn't trigger a loss of focus. For example, if I have a field "email address" and a Button "Send Email", and I have a focus lost handler to commit the email address textfield to an underlying model, then pressing the Button will not trigger that handler and the underlying model may not have been updated with the latest edits. Solutions to trigger the correct action are all a bit tricky or annoying: - Query all fields for their current contents as focus lost is not entirely reliable for this purpose - Have fields update models immediately (which would be on every key press...) -- this is not very efficient, and can get in the way of validation / model restrictions - Have controls listen to a "COMMIT" event (this is fired at the current focus owner by the Button). This event may be veto'd if committing the value resulted in a validation error, in which case the button press is cancelled I don't like any of these, but using the last option at the moment because I like constant updates and having to requery UI components even less... --John I noticed however that if you edit some field (it doesn't have to be in a table view, just a regular field), and have a focus lost handler that commits the value, that this focus lost handler is insufficient... On 13/10/2025 14:53, [email protected]<mailto:[email protected]> wrote: All, I created an initial poc 1* to support developers to commit the cell value when the focus is lost 2* (including 3*). More specifically, this gives the maximum flexibility to choose what should happen when the focus is lost or the editing index changed (which may happen when clicking into another cell while editing). All information mentioned here are also in the description of the PR. API - Instead of calling `cancelEdit`, every cell now calls `stopEdit` when the focus is lost or the editing index changed. The default behavior is cancelling the edit, but developers can now override the behavior and allow a `commitEdit` instead - There are multiple 'events' that can lead to a editing change. Every change will now call `stopEdit`. It is therefore the responsibility of the developer to decide, when it makes sense to actually commit the value instead of cancelling it. This decision was made as the behavior is manipulating the editing index, but you as a developer can as well. We do not really know what intention led to e.g. a change of the editing index. - Every `MOUSE_PRESSED` shifts the focus to the cell container, which is undesired in case of editing the cell. So this event is now consumed. - All `TextField` cells now commit their value (instead of cancel) on focus loss - `TextField` Escape handling was badly implemented (it was never really called, as the cell container handled Escape before) Considerations - I tried to make the API minimal, and without breaking changes (other than the `TextField` cells committing their values, but we may split this up) - The Cell Container focus behavior is, well, weird right now. That is why consuming the event is needed to better support this PR. One thing we may can consider is using the `focusWithin` property instead for all 4 Cell Containers and not calling `requestFocus` for nearly every `MOUSE_PRESSED` event. If we decide so, this is needs to be done before merging this PR. - Clicking the `ScrollBar` now commits/cancels the edit. I checked other applications and this is very common. But something I need to note here. This probably can be fixed in the same way mentioned above (`focusWithin`) - It might be hard for a developer to exactly know the cause why `stopEdit` is called. This does not seem like a problem, as e.g. for a `TextField`, you normally register listeners for e.g. pressing the Escape key on it, so you keep full control. Another Approach - Another Approach I tested could be to request the focus to a cell when clicked/edited, to ensure that the focus listener is ALWAYS called before another cell will reach the editing state. Again, we probably need to change the focus handling to e.g. use the `focusWithin` property. With this approach, we can only call `stopEdit` when the focus changed (since it is now called always), but not when the editing index changed. 1* - https://github.com/openjdk/jfx/pull/1935 2* - https://bugs.openjdk.org/browse/JDK-8089514 3* - https://bugs.openjdk.org/browse/JDK-8089311 -- Marius
