On Sat, 30 Aug 2025 15:46:29 GMT, Nir Lisker <[email protected]> wrote:
>> Adds `MOUSE_DRAG_DONE` event type to `MouseDragEvent` and appropriate
>> handlers.
>
> Nir Lisker has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Missing @since
This looks like a good addition.
I left a comment recommending to revert the markdown-style comments. There
doesn't seem to be a good reason to use them for the two new properties and new
static final constant.
modules/javafx.graphics/src/main/java/javafx/scene/Node.java line 7714:
> 7712: }
> 7713:
> 7714: public final EventHandler<? super MouseDragEvent>
> getOnMouseDragDone() {
We normally put the property methods that will inherit the docs below the
method (or private property as the case may be) that has the javadoc comments.
I recommend to move these two methods below the `onMouseDragDoneProperty`
method.
-------------
PR Review: https://git.openjdk.org/jfx/pull/1873#pullrequestreview-3325642083
PR Review Comment: https://git.openjdk.org/jfx/pull/1873#discussion_r2421880414
