On Thu, 9 Oct 2025 03:21:20 GMT, Jay Bhaskar <[email protected]> wrote:
> WebKitGTK 2.48.6 and 2.48.7 are bug-fix releases that improve stability, fix > crashes, memory leaks, emoji rendering, WebP animation stuttering, and CSS > animation issues, while also adding better font support and preventing > unnecessary memory monitoring. My testing looks good. As for the changes themselves, I added one inline comment about a change that seems unnecessary, in that it didn't come from upstream. The file in question, `Source/WebCore/Modules/compression/CompressionStreamEncoder.cpp`, was not modified between 2.48.5 and 2.48.7. Conversely, I see one file that _was_ modified upstream between 2.48.5 and 2.48.7 for which you didn't pick up the changes: Source/cmake/OptionsGTK.cmake Was this intentional or was it missed? I realize that we probably don't use it in our build, but we updated this for WebKit 622.1, so I would have expected to see it updated here. modules/javafx.web/src/main/native/Source/WebCore/Modules/compression/CompressionStreamEncoder.cpp line 91: > 89: return result != Z_OK && result != Z_STREAM_END && result != > Z_BUF_ERROR; > 90: #endif > 91: return true; I don't understand this change. It didn't come from upstream, since this file wasn't changed in the upstream code between 2.48.5 and 2.48.7? I'm surprised that removing this return statement didn't cause a compilation failure for the `PLATFORM(JAVA)` case (i.e., for JavaFX), but somehow doesn't. Possibly it is just being treated as a warning rather than an error. I recommend to revert this change (i.e., revert this file). ------------- PR Review: https://git.openjdk.org/jfx/pull/1933#pullrequestreview-3320119361 PR Review Comment: https://git.openjdk.org/jfx/pull/1933#discussion_r2417588372
