> When changing the width and height of a window the platform code is 
> responsible for enforcing the min and max size constraints. If the final 
> width and height don't match the width and height passed into setBounds the 
> platform needs to call notifyResize to correct the window's properties. This 
> happens naturally if the window size actually changes since that will trigger 
> the OS to send size change notifications. If the platform window size doesn't 
> change the OS notifications won't trigger. We need to catch that case and 
> send notifyResize anyway.
> 
> This PR does this for Mac and Windows. Linux is being handled in PR #1789 
> which also includes the system tests for these bugs.

Martin Fox has updated the pull request with a new target base due to a merge 
or a rebase. The incremental webrev excludes the unrelated changes brought in 
by the merge/rebase. The pull request contains six additional commits since the 
last revision:

 - Merge remote-tracking branch 'upstream/master' into sendcorrectsize
 - Remove double notifications, keep window min/max/normal state unchanged.
 - If min/max window size enforced send notification to correct Window 
properties
 - Merge remote-tracking branch 'upstream/master' into sendcorrectsize
 - Comment cleanup
 - Notify WindowStage if setBounds didn't change the size as expected

-------------

Changes:
  - all: https://git.openjdk.org/jfx/pull/1870/files
  - new: https://git.openjdk.org/jfx/pull/1870/files/468fd354..c270bff8

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jfx&pr=1870&range=02
 - incr: https://webrevs.openjdk.org/?repo=jfx&pr=1870&range=01-02

  Stats: 900761 lines in 10082 files changed: 382955 ins; 393786 del; 124020 mod
  Patch: https://git.openjdk.org/jfx/pull/1870.diff
  Fetch: git fetch https://git.openjdk.org/jfx.git pull/1870/head:pull/1870

PR: https://git.openjdk.org/jfx/pull/1870

Reply via email to