On Wed, 11 Jun 2025 20:17:39 GMT, Kevin Rushforth <[email protected]> wrote:

>> Kevin Rushforth has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   Cleanup for review comments
>
> Thanks for the reviews.

@kevinrushforth More of a follow-up question rather than a bug report yet 
(apologies if this is not the right avenue). I found usage of 
[sun.misc.BASE64Encoder](https://github.com/openjdk/jfx/blob/c77c2335856a967907aaacc9546f44943c069add/modules/javafx.web/src/android/java/javafx/scene/web/WebEngine.java#L478)
 in `javafx.web` module as well as 
[jdk.unsupported](https://github.com/openjdk/jfx/blob/c77c2335856a967907aaacc9546f44943c069add/modules/javafx.graphics/src/main/java/module-info.java#L45)
 still referenced in javafx.graphics.

Would those need to be addressed as well (assuming the end goal was to remove 
all sun.misc references)? I'm also naively assuming the requires on 
`jdk.unsupported` can be dropped after these changes unless I'm mistaken.

-------------

PR Comment: https://git.openjdk.org/jfx/pull/1814#issuecomment-3475802120

Reply via email to