On Mon, 3 Nov 2025 12:51:20 GMT, Ziad El Midaoui <[email protected]> wrote:
>> Andy Goryachev has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains three additional >> commits since the last revision: >> >> - Merge branch 'master' into 8366202.wrong >> - review comments >> - wrong style > > The test works fine, I tried it in the RTA Demo and adding text in middle of > sentence keeps the styles of the preceding text. > > I noticed one thing is that when clicking at the end of a line of text (or > anywhere in the middle) and then changing the color or style it changes the > whole line style and color, shouldn't the new color and style be applied on > the newly typed text only and not change the existing text color? > This happens also on master so maybe it's not related to this issue directly > steps to reproduce : > > 1. Write "testing testing testing" > 2. click somewhere on this text without selecting any text > 3. change color > 4. notice the whole text is changing color (normally it shouldn't change > colors of the existing text only the newly typed text) @Ziad-Mid yes, that's the way it's implemented in the demo, for simplicity sake. Out of scope for this PR, but it should be changed to the way other editors operate. ------------- PR Comment: https://git.openjdk.org/jfx/pull/1950#issuecomment-3481204545
