On Wed, 29 Oct 2025 15:10:43 GMT, Ziad El Midaoui <[email protected]> wrote:
> Added new method `setSquareSize(double size)` to be able to customize the > size of squares in `ColorPalette` which was previously hardcoded with a value > 15 This is a good question. We already have a can of worms on our hands, so we need to figure out what to do with it. First of all, we should decide (speaking generally) what properties should be in the control, to be applied to all the possible skins, and which properties are specific to a particular Skin implementation. In this particular case, the size of the grid cell does not seem to belong to the control, it's clearly a property of the skin. Then, we need to decide whether we allow extending that particular skin, and the degree in which we allow this. We may want to document the structure (hierarchy and style classes) of the skin - maybe in cssref.html, or in the skin's javadoc or similar place (Example: VFlow:78). Keep in mind that we do support both modena and caspian themes, to any changes to styles need to be reflected in both. Or maybe even go further and design the skins explicitly to allow extension - using extendable classes and methods. Then, of course, there is a question of extending behavior and that's where the discussion stalls. What do you think? ------------- PR Comment: https://git.openjdk.org/jfx/pull/1954#issuecomment-3481991172
