On Tue, 4 Nov 2025 20:40:36 GMT, Kevin Rushforth <[email protected]> wrote:
>> Andy Goryachev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> get text
>
> modules/jfx.incubator.richtext/src/main/java/jfx/incubator/scene/control/richtext/CodeArea.java
> line 468:
>
>> 466: * @defaultValue null
>> 467: */
>> 468: public final ObjectProperty<LineEnding> lineEndingProperty() {
>
> Shouldn't this be a property of RichTextArea?
No, `RichTextArea` might have a model that has no concept of line ending, or
has its own idea of line ending - that's why it's an attribute of the model
rather than the property in the control.
`CodeArea`, on the other hand, deals with plain text as an underlying data, so
line ending is a property of the control, just like `font` and `tabSize`.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1944#discussion_r2492375075
