On Thu, 6 Nov 2025 19:53:28 GMT, Kevin Rushforth <[email protected]> wrote:
>> Andy Goryachev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> removed property
>
> modules/jfx.incubator.richtext/src/main/java/jfx/incubator/scene/control/richtext/model/StyledTextModel.java
> line 1023:
>
>> 1021: if (lineEnding == null) {
>> 1022: lineEnding = LineEnding.SYSTEM;
>> 1023: }
>
> This isn't needed, right? `lineEnding` can never be null as long as you
> initialize it to `LineEnding.SYSTEM `, since you check and throw on an
> attempt to set it to null.
tried to do a lazy init, but it's not that essential.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1944#discussion_r2500639682
