On Fri, 31 Oct 2025 00:07:46 GMT, Michael Strauß <[email protected]> wrote:
>> Adds the `DialogPane.headerBar` property, which allows developers to specify
>> a custom `HeaderBar` when the dialog uses the `EXTENDED` stage style.
>
> Michael Strauß has updated the pull request incrementally with one additional
> commit since the last revision:
>
> move HeaderBar to DialogPane
This might be a silly question: is there a need for split `HeaderBar`s?
modules/javafx.controls/src/main/java/javafx/scene/control/Dialog.java line 467:
> 465: * Specifies the style for this dialog. This must be done prior to
> making the dialog visible.
> 466: * <p>
> 467: * Note that a dialog with the {@link StageStyle#EXTENDED} style
> must also specify a {@link HeaderBar} with
must or should? meaning, is it a requirement, or just a warning?
if the latter, it might be better to say something like "the dialog will not be
draggable if the header bar is not set"
modules/javafx.controls/src/main/java/javafx/scene/control/DialogPane.java line
1020:
> 1018: /** {@inheritDoc} */
> 1019: @Override protected double computeMinWidth(double height) {
> 1020: double headerBarMinWidth = getHeaderBar() instanceof HeaderBar
> hb ? hb.minWidth(height) : 0;
clever! :-)
-------------
PR Comment: https://git.openjdk.org/jfx/pull/1943#issuecomment-3499836327
PR Review Comment: https://git.openjdk.org/jfx/pull/1943#discussion_r2500831479
PR Review Comment: https://git.openjdk.org/jfx/pull/1943#discussion_r2500981553
